From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Date: Wed, 5 Jun 2013 02:16:33 +0000 (+0800)
Subject: iwlegacy: fix error return code in il3945_pci_probe()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ca3ae51396c049fcb9a93ded6f90ec81f7360ffa;p=linux-beck.git

iwlegacy: fix error return code in il3945_pci_probe()

Fix to return a negative error code in the il3945_hw_set_hw_params() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index b37a582ccbe7..866ce6c68405 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -3727,7 +3727,8 @@ il3945_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	 * 5. Setup HW Constants
 	 * ********************/
 	/* Device-specific setup */
-	if (il3945_hw_set_hw_params(il)) {
+	err = il3945_hw_set_hw_params(il);
+	if (err) {
 		IL_ERR("failed to set hw settings\n");
 		goto out_eeprom_free;
 	}