From: Brian Masney Date: Sat, 12 Nov 2016 18:19:20 +0000 (-0500) Subject: staging: iio: tsl2583: remove redundant write to the control register in taos_probe() X-Git-Tag: v4.10-rc1~148^2~229^2~21 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=cade8cde796cc330b23f62a24c93d754df62c949;p=karo-tx-linux.git staging: iio: tsl2583: remove redundant write to the control register in taos_probe() taos_probe() calls i2c_smbus_write_byte() to select the control register, however there are no subsequent calls to i2c_smbus_read_byte(). The write call is unnecessary and is removed by this patch. Verified that the driver still functions correctly using a TSL2581 hooked up to a Raspberry Pi 2. Signed-off-by: Brian Masney Signed-off-by: Jonathan Cameron --- diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c index 5a32102e72d1..449506bdffa4 100644 --- a/drivers/staging/iio/light/tsl2583.c +++ b/drivers/staging/iio/light/tsl2583.c @@ -788,14 +788,6 @@ static int taos_probe(struct i2c_client *clientp, return -EINVAL; } - ret = i2c_smbus_write_byte(clientp, (TSL258X_CMD_REG | TSL258X_CNTRL)); - if (ret < 0) { - dev_err(&clientp->dev, - "i2c_smbus_write_byte() to cmd reg failed in taos_probe(), err = %d\n", - ret); - return ret; - } - indio_dev->info = &tsl2583_info; indio_dev->channels = tsl2583_channels; indio_dev->num_channels = ARRAY_SIZE(tsl2583_channels);