From: Devendra Naga Date: Mon, 18 Jun 2012 17:44:31 +0000 (+0530) Subject: pinctrl/pinctrl-tegra: remove IS_ERR checking of pmx->pctl X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=cb0f7d35e385fc242c76bfe7f1d68c1904c6f965;p=linux-beck.git pinctrl/pinctrl-tegra: remove IS_ERR checking of pmx->pctl pinctrl_register returns a pointer of struct type struct pinctrl_dev, if successfully registered to pinctrl subsystem, otherwise returns NULL, and there wont' be any pointers which are not dereferencible. They are not type of pointer addresses but are kind of error codes rather actual addresses, but are a kind of return codes of functions returning integer types. return -ENODEV if device registration fails. Acked-by: Stephen Warren Signed-off-by: Devendra Naga Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c index 07228b17a370..ae52e4e5d098 100644 --- a/drivers/pinctrl/pinctrl-tegra.c +++ b/drivers/pinctrl/pinctrl-tegra.c @@ -745,9 +745,9 @@ int __devinit tegra_pinctrl_probe(struct platform_device *pdev, } pmx->pctl = pinctrl_register(&tegra_pinctrl_desc, &pdev->dev, pmx); - if (IS_ERR(pmx->pctl)) { + if (!pmx->pctl) { dev_err(&pdev->dev, "Couldn't register pinctrl driver\n"); - return PTR_ERR(pmx->pctl); + return -ENODEV; } pinctrl_add_gpio_range(pmx->pctl, &tegra_pinctrl_gpio_range);