From: Wang Sheng-Hui Date: Thu, 27 Sep 2012 12:00:01 +0000 (-0400) Subject: ext4: remove redundant offset check in mext_check_arguments() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=cbb4ee830e0057f8d60b4e0a8c4b6daa6cdd28d7;p=linux-beck.git ext4: remove redundant offset check in mext_check_arguments() In the check code above, if orig_start != donor_start, we would return -EINVAL. So here, orig_start should be equal with donor_start. Remove the redundant check here. Signed-off-by: Wang Sheng-Hui Signed-off-by: "Theodore Ts'o" --- diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index c2e47da7c2ba..cee4bd066b7a 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -1134,7 +1134,6 @@ mext_check_arguments(struct inode *orig_inode, } if ((orig_start >= EXT_MAX_BLOCKS) || - (donor_start >= EXT_MAX_BLOCKS) || (*len > EXT_MAX_BLOCKS) || (orig_start + *len >= EXT_MAX_BLOCKS)) { ext4_debug("ext4 move extent: Can't handle over [%u] blocks "