From: Peter Hurley Date: Wed, 24 Sep 2014 10:26:21 +0000 (-0400) Subject: tty: Fix width of unsigned long bitfield padding X-Git-Tag: v3.18-rc1~129^2~23 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=cc952e7017fa2e8871ee6a94f2c606ff5911f61e;p=karo-tx-linux.git tty: Fix width of unsigned long bitfield padding Commit c545b66c6922b002b5fe224a6eaec58c913650b5, 'tty: Serialize tcflow() with other tty flow control changes' and commit 99416322dd16b810ba74098cc50ef2a844091d35, 'tty: Workaround Alpha non-atomic byte storage in tty_struct' work around compiler bugs and non-atomic storage on multiple arches by padding bitfields out to the declared type which is unsigned long. However, the width varies by arch. Pad bitfields to actual width of unsigned long (which is BITS_PER_LONG). Reported-by: Fengguang Wu Signed-off-by: Peter Hurley Signed-off-by: Greg Kroah-Hartman --- diff --git a/include/linux/tty.h b/include/linux/tty.h index 546e94557895..5171ef8f7b85 100644 --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -264,11 +264,11 @@ struct tty_struct { struct winsize winsize; /* winsize_mutex */ unsigned long stopped:1, /* flow_lock */ flow_stopped:1, - unused:62; + unused:BITS_PER_LONG - 2; int hw_stopped; unsigned long ctrl_status:8, /* ctrl_lock */ packet:1, - unused_ctrl:55; + unused_ctrl:BITS_PER_LONG - 9; unsigned int receive_room; /* Bytes free for queue */ int flow_change;