From: Ville Syrjälä Date: Tue, 5 May 2015 14:17:27 +0000 (+0300) Subject: drm/i915: Remove a bogus 12bpc "toggle" from intel_disable_hdmi() X-Git-Tag: v4.2-rc1~33^2~45 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ccbaefa09d73f8724b3040b80a2521454af61ae4;p=karo-tx-linux.git drm/i915: Remove a bogus 12bpc "toggle" from intel_disable_hdmi() The IBX 12bpc port enable toggle is only relevant when enabling the port, not when disabling it. Also this code doesn't actually toggle anything, and essentially just writes the port register one extra time. Furthermore CPT/PPT don't need such workarounds and yet we include them. Just kill it. Signed-off-by: Ville Syrjälä Reviewed-by: Jesse Barnes Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index d04e6dc97fe5..91e152c15271 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -904,14 +904,6 @@ static void intel_disable_hdmi(struct intel_encoder *encoder) } } - /* HW workaround, need to toggle enable bit off and on for 12bpc, but - * we do this anyway which shows more stable in testing. - */ - if (HAS_PCH_SPLIT(dev)) { - I915_WRITE(intel_hdmi->hdmi_reg, temp & ~SDVO_ENABLE); - POSTING_READ(intel_hdmi->hdmi_reg); - } - temp &= ~enable_bits; I915_WRITE(intel_hdmi->hdmi_reg, temp);