From: Sathya Perla Date: Mon, 10 Aug 2009 03:43:23 +0000 (+0000) Subject: be2net: fix bad queue traversal in be_rx_q_clean() X-Git-Tag: v2.6.32-rc1~703^2~426 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=cdab23b7017693c00dd69fa28bcdf5b0434b3838;p=karo-tx-linux.git be2net: fix bad queue traversal in be_rx_q_clean() Using "for(tail != head)" to traverse a queue from tail to head fails in the case of a fully filled queue. Use "for(used != 0)" instead. Signed-off-by: Sathya Perla Signed-off-by: David S. Miller --- diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index acce6a639324..9bbf447ee28f 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c @@ -1010,7 +1010,7 @@ static void be_rx_q_clean(struct be_adapter *adapter) /* Then free posted rx buffer that were not used */ tail = (rxq->head + rxq->len - atomic_read(&rxq->used)) % rxq->len; - for (; tail != rxq->head; index_inc(&tail, rxq->len)) { + for (; atomic_read(&rxq->used) > 0; index_inc(&tail, rxq->len)) { page_info = get_rx_page_info(adapter, tail); put_page(page_info->page); memset(page_info, 0, sizeof(*page_info));