From: Loic Poulain Date: Tue, 27 Jun 2017 17:15:07 +0000 (+0200) Subject: Bluetooth: hci_bcm: Fix unwanted error reporting if no bcm dev X-Git-Tag: v4.13-rc1~157^2~38^2~7 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=cdd24a200a8fa39e383890bbf862c0aa83ba83f5;p=karo-tx-linux.git Bluetooth: hci_bcm: Fix unwanted error reporting if no bcm dev The hci_bcm proto is able to operate without bcm platform device linked to its uart port. In that case, firmware can be applied, but there is no power operation (no gpio/irq resources mgmt). However, the current implementation breaks this use case because of reporting a ENODEV error in the bcm setup procedure if bcm_request_irq fails (which is the case if no bcm device linked). Fix this by removing bcm_request_irq error forwarding. Signed-off-by: Loic Poulain Reported-by: Ian Molton Signed-off-by: Marcel Holtmann --- diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index d2e9e2d1b014..192ad2781733 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -419,8 +419,7 @@ finalize: if (err) return err; - err = bcm_request_irq(bcm); - if (!err) + if (!bcm_request_irq(bcm)) err = bcm_setup_sleep(hu); return err;