From: H Hartley Sweeten Date: Mon, 3 Feb 2014 17:43:27 +0000 (-0700) Subject: staging: comedi: amplc_pci230: standardize error handling of subdev_8255_init() X-Git-Tag: next-20140306~21^2~499 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ce921ae41919d033b4cd1d639f2a5f42dd41e802;p=karo-tx-linux.git staging: comedi: amplc_pci230: standardize error handling of subdev_8255_init() The subdev_8255_init() call returns 0 for success of a negative errno for failure. For aesthetics, change the error test in this driver from (rc < 0) to simply (rc) to follow the style of the other users of this function. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c index c08dfbbe4062..8b8b2ac4bf7f 100644 --- a/drivers/staging/comedi/drivers/amplc_pci230.c +++ b/drivers/staging/comedi/drivers/amplc_pci230.c @@ -2762,8 +2762,8 @@ static int pci230_attach_common(struct comedi_device *dev, /* digital i/o subdevice */ if (thisboard->have_dio) { rc = subdev_8255_init(dev, s, NULL, - (devpriv->iobase1 + PCI230_PPI_X_BASE)); - if (rc < 0) + devpriv->iobase1 + PCI230_PPI_X_BASE); + if (rc) return rc; } else { s->type = COMEDI_SUBD_UNUSED;