From: H Hartley Sweeten <hsweeten@visionengravers.com>
Date: Tue, 3 May 2016 19:30:00 +0000 (-0700)
Subject: staging: comedi: das16m1: minor cleanup to das16m1_ai_insn_read()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d0e50e6588e236c17f494b3055be986344692af9;p=linux-beck.git

staging: comedi: das16m1: minor cleanup to das16m1_ai_insn_read()

The (*insn_read) functions return the number of data values read. The 'n'
value is correct but for clarity change the return to 'insn->n'.

For aesthetics, change the 'n' loop variable name to 'i'. That's more common
in comedi drivers.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/drivers/das16m1.c b/drivers/staging/comedi/drivers/das16m1.c
index d4b1b92cb112..c0f279638cd8 100644
--- a/drivers/staging/comedi/drivers/das16m1.c
+++ b/drivers/staging/comedi/drivers/das16m1.c
@@ -324,11 +324,11 @@ static int das16m1_ai_insn_read(struct comedi_device *dev,
 				unsigned int *data)
 {
 	int ret;
-	int n;
+	int i;
 
 	das16m1_ai_set_queue(dev, &insn->chanspec, 1);
 
-	for (n = 0; n < insn->n; n++) {
+	for (i = 0; i < insn->n; i++) {
 		unsigned short val;
 
 		/* clear interrupt */
@@ -341,10 +341,10 @@ static int das16m1_ai_insn_read(struct comedi_device *dev,
 			return ret;
 
 		val = inw(dev->iobase + DAS16M1_AI_REG);
-		data[n] = DAS16M1_AI_TO_SAMPLE(val);
+		data[i] = DAS16M1_AI_TO_SAMPLE(val);
 	}
 
-	return n;
+	return insn->n;
 }
 
 static int das16m1_di_insn_bits(struct comedi_device *dev,