From: Alex Xie Date: Mon, 24 Apr 2017 19:26:57 +0000 (-0400) Subject: drm/amdgpu: Real return value can be over-written when clean up X-Git-Tag: v4.12-rc1~9^2~2^2~50 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d159f26caaa91c88e9078c69fd159be9cec3a005;p=karo-tx-linux.git drm/amdgpu: Real return value can be over-written when clean up Signed-off-by: Alex Xie Reviewed-by: Christian König Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c index cc97eee93226..726b3e018eeb 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c @@ -117,6 +117,11 @@ static void amdgpu_benchmark_move(struct amdgpu_device *adev, unsigned size, } out_cleanup: + /* Check error value now. The value can be overwritten when clean up.*/ + if (r) { + DRM_ERROR("Error while benchmarking BO move.\n"); + } + if (sobj) { r = amdgpu_bo_reserve(sobj, false); if (likely(r == 0)) { @@ -133,10 +138,6 @@ out_cleanup: } amdgpu_bo_unref(&dobj); } - - if (r) { - DRM_ERROR("Error while benchmarking BO move.\n"); - } } void amdgpu_benchmark(struct amdgpu_device *adev, int test_number)