From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Wed, 31 May 2006 09:55:17 +0000 (+0200)
Subject: [ALSA] NULL pointer dereference in sound/synth/emux/soundfont.c
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d20cad602fc3d92902dc3b4ed252359ab05eae0f;p=linux-beck.git

[ALSA] NULL pointer dereference in sound/synth/emux/soundfont.c

this is about coverity id #100.
It seems the if statement is negated, since the else branch calls
remove_info() with sflist->currsf as a parameter where it gets
dereferenced.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/synth/emux/soundfont.c b/sound/synth/emux/soundfont.c
index 7f0bdea0dfd3..455e535933ec 100644
--- a/sound/synth/emux/soundfont.c
+++ b/sound/synth/emux/soundfont.c
@@ -195,7 +195,7 @@ snd_soundfont_load(struct snd_sf_list *sflist, const void __user *data,
 		break;
 	case SNDRV_SFNT_REMOVE_INFO:
 		/* patch must be opened */
-		if (sflist->currsf) {
+		if (!sflist->currsf) {
 			snd_printk("soundfont: remove_info: patch not opened\n");
 			rc = -EINVAL;
 		} else {