From: Sachin Kamat Date: Fri, 25 Jan 2013 18:18:09 +0000 (-0800) Subject: cpufreq: exynos: Fix unsigned variable being checked for negative value X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d271d077ac66e839a0f443f1089a0af1ef15fd51;p=linux-beck.git cpufreq: exynos: Fix unsigned variable being checked for negative value exynos_cpufreq_scale function returns signed value which was assigned to an unsigned variable and checked for negative value which is always false. Hence make it signed. Fixes the following smatch warnings: drivers/cpufreq/exynos-cpufreq.c:83 exynos_cpufreq_scale() warn: unsigned 'old_index' is never less than zero. drivers/cpufreq/exynos-cpufreq.c:89 exynos_cpufreq_scale() warn: unsigned 'index' is never less than zero. Signed-off-by: Sachin Kamat Signed-off-by: Kukjin Kim --- diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 0840358bf3bc..c8c7653a6033 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -65,7 +65,7 @@ static int exynos_cpufreq_scale(unsigned int target_freq) struct cpufreq_policy *policy = cpufreq_cpu_get(0); unsigned int arm_volt, safe_arm_volt = 0; unsigned int mpll_freq_khz = exynos_info->mpll_freq_khz; - unsigned int index, old_index; + int index, old_index; int ret = 0; freqs.old = policy->cur;