From: David Kershner Date: Wed, 9 Mar 2016 02:28:28 +0000 (-0500) Subject: staging: unisys: visorbus: clean up visorchannel_clear X-Git-Tag: v4.6-rc1~103^2~238 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d342c060433a0f5b6b710cf2ab2591576c2f2d62;p=karo-tx-linux.git staging: unisys: visorbus: clean up visorchannel_clear Goto label was ambiguous change to out_free_page to signify that we will always go through the path even on success. Signed-off-by: David Kershner Signed-off-by: Timothy Sell Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorchannel.c index ba26b5443211..b68a904ac617 100644 --- a/drivers/staging/unisys/visorbus/visorchannel.c +++ b/drivers/staging/unisys/visorbus/visorchannel.c @@ -293,14 +293,14 @@ visorchannel_clear(struct visorchannel *channel, ulong offset, u8 ch, err = visorchannel_write(channel, offset + written, buf, thisbytes); if (err) - goto cleanup; + goto out_free_page; written += thisbytes; nbytes -= thisbytes; } err = 0; -cleanup: +out_free_page: free_page((unsigned long)buf); return err; }