From: Kevin McKinney <klmckinney1@gmail.com>
Date: Fri, 7 Oct 2011 22:50:12 +0000 (-0400)
Subject: Staging: bcm: Fix assignment issue in if statement reported by checkpatch.pl.
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d491061b98bf3d2d036b9896f884403cdc2c0327;p=mv-sheeva.git

Staging: bcm: Fix assignment issue in if statement reported by checkpatch.pl.

This patch fixes an error where an assignment "="
was being used in an if statement to determine if
Firmware was downloaded. This patch removes that
assignment, and places it above the if statement.
The if statement then evaluates the status to
verify if "0" successful, or != 0 failure.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 0882e04963a..e9f29d59751 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -1045,7 +1045,8 @@ int InitCardAndDownloadFirmware(PMINI_ADAPTER ps_adapter)
 	}
 
 	/* Download Firmare */
-	if ((status = BcmFileDownload(ps_adapter, BIN_FILE, FIRMWARE_BEGIN_ADDR))) {
+	status = BcmFileDownload(ps_adapter, BIN_FILE, FIRMWARE_BEGIN_ADDR);
+	if (status != 0) {
 		BCM_DEBUG_PRINT(ps_adapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "No Firmware File is present...\n");
 		goto OUT;
 	}