From: NeilBrown Date: Thu, 25 Jan 2007 04:35:25 +0000 (+1100) Subject: [PATCH] md: make 'repair' actually work for raid1. X-Git-Tag: v2.6.19.3~21 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d53c44cb93ba219bc26fa2f7ddd98bdd4d219c9c;p=karo-tx-linux.git [PATCH] md: make 'repair' actually work for raid1. When 'repair' finds a block that is different one the various parts of the mirror. it is meant to write a chosen good version to the others. However it currently writes out the original data to each. The memcpy to make all the data the same is missing. Signed-off-by: Neil Brown Signed-off-by: Chris Wright --- diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 99d453fd7162..77b19b4d0a11 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1266,6 +1266,11 @@ static void sync_request_write(mddev_t *mddev, r1bio_t *r1_bio) sbio->bi_sector = r1_bio->sector + conf->mirrors[i].rdev->data_offset; sbio->bi_bdev = conf->mirrors[i].rdev->bdev; + for (j = 0; j < vcnt ; j++) + memcpy(page_address(sbio->bi_io_vec[j].bv_page), + page_address(pbio->bi_io_vec[j].bv_page), + PAGE_SIZE); + } } }