From: Peter Hurley <peter@hurleysoftware.com>
Date: Sun, 10 Apr 2016 03:49:42 +0000 (-0700)
Subject: serial: 8250: Reduce expr in 8250 irq handler
X-Git-Tag: v4.7-rc1~94^2~36
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d601744dc145a27945e97d643d2f5d298ab40627;p=karo-tx-linux.git

serial: 8250: Reduce expr in 8250 irq handler

If !up->dma == F, then up->dma == T and can be elided from the
(up->dma && up->dma->tx_err) sub-expression.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 40d2d303dc7f..b2bbb9dcfa0b 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -1811,8 +1811,7 @@ int serial8250_handle_irq(struct uart_port *port, unsigned int iir)
 			status = serial8250_rx_chars(up, status);
 	}
 	serial8250_modem_status(up);
-	if ((!up->dma || (up->dma && up->dma->tx_err)) &&
-	    (status & UART_LSR_THRE))
+	if ((!up->dma || up->dma->tx_err) && (status & UART_LSR_THRE))
 		serial8250_tx_chars(up);
 
 	spin_unlock_irqrestore(&port->lock, flags);