From: Alex Gartrell Date: Mon, 6 Oct 2014 20:30:08 +0000 (-0700) Subject: ipvs: remove unnecessary assignment in __ip_vs_get_out_rt X-Git-Tag: v3.19-rc1~118^2~122^2~11^2 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d7701089118d23bfed03bad0a6b5cc5115990c9e;p=karo-tx-linux.git ipvs: remove unnecessary assignment in __ip_vs_get_out_rt It is a precondition of the function that daddr be equal to dest->addr.ip if dest is non-NULL, so this additional assignment is just confusing for stupid engineers like me. Signed-off-by: Alex Gartrell Signed-off-by: Simon Horman --- diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c index 91f17c1eb8a2..5efa59792505 100644 --- a/net/netfilter/ipvs/ip_vs_xmit.c +++ b/net/netfilter/ipvs/ip_vs_xmit.c @@ -293,7 +293,6 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest, &dest->addr.ip, &dest_dst->dst_saddr.ip, atomic_read(&rt->dst.__refcnt)); } - daddr = dest->addr.ip; if (ret_saddr) *ret_saddr = dest_dst->dst_saddr.ip; } else {