From: Fan Li Date: Tue, 13 Sep 2016 03:35:42 +0000 (+0800) Subject: f2fs: exclude special cases for f2fs_move_file_range X-Git-Tag: v4.9-rc1~105^2~30 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d95fd91c1ac1f551909ccdc4fcc80159521d0ef5;p=karo-tx-linux.git f2fs: exclude special cases for f2fs_move_file_range When src and dst is the same file, and the latter part of source region overlaps with the former part of destination region, current implement will overwrite data which hasn't been moved yet and truncate data in overlapped region. This patch return -EINVAL when such cases occur and return 0 when source region and destination region is actually the same part of the same file. Signed-off-by: Fan li Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 40fe72e5147c..d400380a8630 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2092,6 +2092,13 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in, if (f2fs_encrypted_inode(src) || f2fs_encrypted_inode(dst)) return -EOPNOTSUPP; + if (src == dst) { + if (pos_in == pos_out) + return 0; + if (pos_out > pos_in && pos_out < pos_in + len) + return -EINVAL; + } + inode_lock(src); if (src != dst) { if (!inode_trylock(dst)) {