From: H Hartley Sweeten Date: Wed, 14 Oct 2015 00:47:55 +0000 (-0700) Subject: staging: comedi: cb_pcidas: tidy up 8800 caldac calibration subdevice X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=d9b0cde41992bbd9047b435354bd5e2317158748;p=linux-beck.git staging: comedi: cb_pcidas: tidy up 8800 caldac calibration subdevice For aesthetics, add some whitespace to the subdevice init. It's not possible to actually read from the caldac. For convienence the subdevice readback provided by the core is used to return the last value written to the subdevice. Remove the SDF_READABLE flag from the subdev_flags. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c index 04d12bf1f6cd..f34a615df841 100644 --- a/drivers/staging/comedi/drivers/cb_pcidas.c +++ b/drivers/staging/comedi/drivers/cb_pcidas.c @@ -1365,13 +1365,13 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev, s->maxdata = 0xff; s->insn_read = eeprom_read_insn; - /* 8800 caldac */ + /* Calibration subdevice - 8800 caldac */ s = &dev->subdevices[4]; - s->type = COMEDI_SUBD_CALIB; - s->subdev_flags = SDF_READABLE | SDF_WRITABLE | SDF_INTERNAL; - s->n_chan = 8; - s->maxdata = 0xff; - s->insn_write = cb_pcidas_caldac_insn_write; + s->type = COMEDI_SUBD_CALIB; + s->subdev_flags = SDF_WRITABLE | SDF_INTERNAL; + s->n_chan = 8; + s->maxdata = 0xff; + s->insn_write = cb_pcidas_caldac_insn_write; ret = comedi_alloc_subdev_readback(s); if (ret)