From: Larry Finger Date: Wed, 25 Sep 2013 17:57:48 +0000 (-0500) Subject: rtlwifi: rtl8188ee: Fix smatch warning in rtl8188ee/hw.c X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=dab3df5e88b979f8d09860f873ccfaa7a55758d2;p=linux-beck.git rtlwifi: rtl8188ee: Fix smatch warning in rtl8188ee/hw.c Smatch lists the following: CHECK drivers/net/wireless/rtlwifi/rtl8188ee/hw.c drivers/net/wireless/rtlwifi/rtl8188ee/hw.c:149 _rtl88ee_set_fw_clock_on() info: ignoring unreachable code. drivers/net/wireless/rtlwifi/rtl8188ee/hw.c:149 _rtl88ee_set_fw_clock_on() info: ignoring unreachable code. This info message is the result of a real error due to a missing break statement in a "while (1)" loop. Signed-off-by: Larry Finger Cc: Stable [3.10+] Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c index b68cae3024fc..e06971be7df7 100644 --- a/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c @@ -143,6 +143,7 @@ static void _rtl88ee_set_fw_clock_on(struct ieee80211_hw *hw, } else { rtlhal->fw_clk_change_in_progress = false; spin_unlock_bh(&rtlpriv->locks.fw_ps_lock); + break; } }