From: Bob Copeland Date: Fri, 22 Aug 2014 13:18:01 +0000 (-0400) Subject: ath5k: ensure led name is null terminated X-Git-Tag: v3.18-rc1~52^2~133^2~46 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=daf9669bea30aa22d44671e0d9ce90234579e1db;p=karo-tx-linux.git ath5k: ensure led name is null terminated Add the missing null termination after strncpy(). This isn't actually a buffer overflow in this case since we use snprintf() appropriately to fill the buffer passed by the caller, but in the interest of not turning this into a bug down the road, go ahead and force termination here. Found by Coverity. Signed-off-by: Bob Copeland Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/ath/ath5k/led.c b/drivers/net/wireless/ath/ath5k/led.c index 48a6a69b57bc..2062d1190556 100644 --- a/drivers/net/wireless/ath/ath5k/led.c +++ b/drivers/net/wireless/ath/ath5k/led.c @@ -130,6 +130,7 @@ ath5k_register_led(struct ath5k_hw *ah, struct ath5k_led *led, led->ah = ah; strncpy(led->name, name, sizeof(led->name)); + led->name[sizeof(led->name)-1] = 0; led->led_dev.name = led->name; led->led_dev.default_trigger = trigger; led->led_dev.brightness_set = ath5k_led_brightness_set;