From: Daniel Vetter Date: Sat, 5 Apr 2014 08:43:37 +0000 (+0200) Subject: drm/bochs: Remove unnecessary NULL check in bo_unref X-Git-Tag: next-20140502~52^2~1^2~3 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=dcb1ee57780f2f772015ce9f80b2adc671257228;p=karo-tx-linux.git drm/bochs: Remove unnecessary NULL check in bo_unref ttm_bo_unref unconditionally calls kref_put on it's argument, so the thing can't be NULL without already causing Oopses. Spotted by coverity. Reviewed-by: David Herrmann Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c index f488be55d650..4a239e931aff 100644 --- a/drivers/gpu/drm/bochs/bochs_mm.c +++ b/drivers/gpu/drm/bochs/bochs_mm.c @@ -434,9 +434,7 @@ static void bochs_bo_unref(struct bochs_bo **bo) tbo = &((*bo)->bo); ttm_bo_unref(&tbo); - if (tbo == NULL) - *bo = NULL; - + *bo = NULL; } void bochs_gem_free_object(struct drm_gem_object *obj)