From: Denis V. Lunev Date: Fri, 1 Feb 2008 02:44:53 +0000 (-0800) Subject: [IPV4]: Fix memory leak on error path during FIB initialization. X-Git-Tag: v2.6.25-rc1~1089^2~5 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=dce5cbeec32eb5db4d406b732b1256c6f702bde5;p=karo-tx-linux.git [IPV4]: Fix memory leak on error path during FIB initialization. net->ipv4.fib_table_hash is not freed when fib4_rules_init failed. Signed-off-by: Denis V. Lunev Signed-off-by: David S. Miller --- diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index d28261826bc2..d0507f4f848a 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -975,6 +975,7 @@ static struct notifier_block fib_netdev_notifier = { static int __net_init ip_fib_net_init(struct net *net) { + int err; unsigned int i; net->ipv4.fib_table_hash = kzalloc( @@ -985,7 +986,14 @@ static int __net_init ip_fib_net_init(struct net *net) for (i = 0; i < FIB_TABLE_HASHSZ; i++) INIT_HLIST_HEAD(&net->ipv4.fib_table_hash[i]); - return fib4_rules_init(net); + err = fib4_rules_init(net); + if (err < 0) + goto fail; + return 0; + +fail: + kfree(net->ipv4.fib_table_hash); + return err; } static void __net_exit ip_fib_net_exit(struct net *net)