From: Alan Cox Date: Fri, 28 Sep 2012 00:20:30 +0000 (+1000) Subject: binfmt_elf: Uninitialized variable X-Git-Tag: next-20121003~1^2~106 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=dcf731a2c6b0d524eeabf76a67fe66734cf948e3;p=karo-tx-linux.git binfmt_elf: Uninitialized variable load_elf_interp() has interp_map_addr carefully described as "uninitialized_var" and marked so as to avoid a warning. However if you trace the code it is passed into load_elf_interp and then this value is checked against NULL. As this return value isn't used this is actually safe but it freaks various analysis tools that see un-initialized memory addresses being read before their value is ever defined. Set it to NULL as a matter of programming good taste if nothing else Signed-off-by: Alan Cox Signed-off-by: Andrew Morton --- diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 1b4efbc461d2..a6cb3baf9cde 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -880,7 +880,7 @@ static int load_elf_binary(struct linux_binprm *bprm, struct pt_regs *regs) } if (elf_interpreter) { - unsigned long uninitialized_var(interp_map_addr); + unsigned long interp_map_addr = 0; elf_entry = load_elf_interp(&loc->interp_elf_ex, interpreter,