From: Avinash Patil Date: Fri, 5 Dec 2014 17:53:39 +0000 (+0530) Subject: mwifiex: do not delete station entries in del_sta handler X-Git-Tag: v3.19-rc1~118^2~28^2~4 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=dda9ddeb2638d364c42e143e2d351b160767b39f;p=karo-tx-linux.git mwifiex: do not delete station entries in del_sta handler A crash was observed while cfg80211 del_station handler is called while stopping AP. This was happening because we were deleting station list and Rx reorder table entries in del_sta handler. While station entry is being deleted here, it may happen that station deauth event from FW would also try to delete station entry. This patch fixes this crash by not deleting station entries in del_station handler. Entry would be deleted while processing station deauth event; which is triggered by del_station command to FW. Reported by: Tim Shepard Signed-off-by: Avinash Patil Signed-off-by: Cathy Luo Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c index f881044e450d..e111ff51cbc1 100644 --- a/drivers/net/wireless/mwifiex/cfg80211.c +++ b/drivers/net/wireless/mwifiex/cfg80211.c @@ -1308,7 +1308,6 @@ mwifiex_cfg80211_del_station(struct wiphy *wiphy, struct net_device *dev, HostCmd_ACT_GEN_SET, 0, sta_node->mac_addr, true)) return -1; - mwifiex_uap_del_sta_data(priv, sta_node); } } else { wiphy_dbg(wiphy, "%s: mac address %pM\n", __func__, @@ -1321,7 +1320,6 @@ mwifiex_cfg80211_del_station(struct wiphy *wiphy, struct net_device *dev, HostCmd_ACT_GEN_SET, 0, sta_node->mac_addr, true)) return -1; - mwifiex_uap_del_sta_data(priv, sta_node); } }