From: Michał Kępień Date: Thu, 5 Jan 2017 14:14:01 +0000 (+0100) Subject: ata: ahci_xgene: free structure returned by acpi_get_object_info() X-Git-Tag: v4.11-rc1~130^2~23 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=de2518201e526f4491e5856b9818f5c18684a6a7;p=karo-tx-linux.git ata: ahci_xgene: free structure returned by acpi_get_object_info() acpi_get_object_info() allocates the returned structure, which the caller has to free when the call succeeds. Free it when appropriate. Fixes: c9802a4be661 ("ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.") Signed-off-by: Michał Kępień Signed-off-by: Tejun Heo --- diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c index 73b19b277138..c2b5941d9184 100644 --- a/drivers/ata/ahci_xgene.c +++ b/drivers/ata/ahci_xgene.c @@ -821,8 +821,10 @@ static int xgene_ahci_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "%s: Error reading device info. Assume version1\n", __func__); version = XGENE_AHCI_V1; - } else if (info->valid & ACPI_VALID_CID) { - version = XGENE_AHCI_V2; + } else { + if (info->valid & ACPI_VALID_CID) + version = XGENE_AHCI_V2; + kfree(info); } } }