From: NeilBrown <neilb@suse.de>
Date: Tue, 7 Feb 2012 04:35:42 +0000 (+1100)
Subject: lockd: fix arg parsing for grace_period and timeout.
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=de5b8e8e047534aac6bc9803f96e7257436aef9c;p=mv-sheeva.git

lockd: fix arg parsing for grace_period and timeout.

If you try to set grace_period or timeout via a module parameter
to lockd, and do this on a big-endian machine where

   sizeof(int) != sizeof(unsigned long)

it won't work.  This number given will be effectively shifted right
by the difference in those two sizes.

So cast kp->arg properly to get correct result.

Cc: stable@kernel.org
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index c061b9aa7dd..2444780f5cf 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -440,7 +440,7 @@ static int param_set_##name(const char *val, struct kernel_param *kp)	\
 	__typeof__(type) num = which_strtol(val, &endp, 0);		\
 	if (endp == val || *endp || num < (min) || num > (max))		\
 		return -EINVAL;						\
-	*((int *) kp->arg) = num;					\
+	*((type *) kp->arg) = num;					\
 	return 0;							\
 }