From: Daeseok Youn Date: Tue, 15 Jul 2014 09:47:11 +0000 (+0900) Subject: staging: dgap: remove redundant error value check X-Git-Tag: v3.17-rc1~123^2~751 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=dfa30ac13952ee0c2918090815688a909ad074f0;p=karo-tx-linux.git staging: dgap: remove redundant error value check The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check "retval" itself. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 32988a8aead4..10bd0f2e7a32 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@ -2181,10 +2181,7 @@ static int dgap_block_til_ready(struct tty_struct *tty, struct file *file, spin_unlock_irqrestore(&ch->ch_lock, lock_flags); - if (retval) - return retval; - - return 0; + return retval; } /*