From: Steve French <smfrench@gmail.com>
Date: Fri, 27 Mar 2015 06:00:06 +0000 (-0500)
Subject: Fix another dereference before null check warning
X-Git-Tag: v4.0-rc7~11^2~1
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=dfebe40076f3b4966e818eaf94021a7ff788df04;p=karo-tx-linux.git

Fix another dereference before null check warning

null tcon is not possible in these paths so
remove confusing null check

Reported by Coverity (CID 728519)

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@samba.org>
---

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 78b329f07b3b..65cd7a84c8bc 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -1632,7 +1632,7 @@ SMB2_flush(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,
 
 	rc = SendReceive2(xid, ses, iov, 1, &resp_buftype, 0);
 
-	if ((rc != 0) && tcon)
+	if (rc != 0)
 		cifs_stats_fail_inc(tcon, SMB2_FLUSH_HE);
 
 	free_rsp_buf(resp_buftype, iov[0].iov_base);