From: Andrew Morton Date: Thu, 25 Oct 2012 01:14:53 +0000 (+1100) Subject: drop_caches-add-some-documentation-and-info-messsge-checkpatch-fixes X-Git-Tag: next-20121025~1^2~100 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e0a6a72d424221294a52e6d370b467852bf83659;p=karo-tx-linux.git drop_caches-add-some-documentation-and-info-messsge-checkpatch-fixes WARNING: Prefer netdev_notice(netdev, ... then dev_notice(dev, ... then pr_notice(... to printk(KERN_NOTICE ... #112: FILE: fs/drop_caches.c:61: + printk(KERN_NOTICE "%s (%d): dropped kernel caches: %d\n", WARNING: line over 80 characters #113: FILE: fs/drop_caches.c:62: + current->comm, task_pid_nr(current), sysctl_drop_caches); total: 0 errors, 2 warnings, 53 lines checked ./patches/drop_caches-add-some-documentation-and-info-messsge.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Michal Hocko Signed-off-by: Andrew Morton --- diff --git a/fs/drop_caches.c b/fs/drop_caches.c index f72395e60251..f23d2a7ed438 100644 --- a/fs/drop_caches.c +++ b/fs/drop_caches.c @@ -59,7 +59,7 @@ int drop_caches_sysctl_handler(ctl_table *table, int write, return ret; if (write) { printk(KERN_NOTICE "%s (%d): dropped kernel caches: %d\n", - current->comm, task_pid_nr(current), sysctl_drop_caches); + current->comm, task_pid_nr(current), sysctl_drop_caches); if (sysctl_drop_caches & 1) iterate_supers(drop_pagecache_sb, NULL); if (sysctl_drop_caches & 2)