From: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Sat, 5 Apr 2014 08:44:51 +0000 (+0200)
Subject: drm/bochs: Remove unecessary NULL check in gem_free
X-Git-Tag: next-20140502~52^2~1^2~2
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e0c6a73fb191daad6d4ea808a89c6e22ac1b2733;p=karo-tx-linux.git

drm/bochs: Remove unecessary NULL check in gem_free

The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Noticed while chasing coverity reports, somehow this one here was not
flagged.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---

diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
index 4a239e931aff..b9a695d92792 100644
--- a/drivers/gpu/drm/bochs/bochs_mm.c
+++ b/drivers/gpu/drm/bochs/bochs_mm.c
@@ -441,8 +441,6 @@ void bochs_gem_free_object(struct drm_gem_object *obj)
 {
 	struct bochs_bo *bochs_bo = gem_to_bochs_bo(obj);
 
-	if (!bochs_bo)
-		return;
 	bochs_bo_unref(&bochs_bo);
 }