From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Thu, 1 Sep 2011 17:23:16 +0000 (-0500)
Subject: staging: rtl8192e: Fix smatch warning in rtl_wx.c
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e25316a08e7e1ebd3f152b14ed251067b45d2da8;p=linux-beck.git

staging: rtl8192e: Fix smatch warning in rtl_wx.c

Smatch reports the following warning:

  CHECK   drivers/staging/rtl8192e/rtl_wx.c

drivers/staging/rtl8192e/rtl_wx.c +262 r8192se_wx_set_radio(16) warn: inconsistent returns sem:&priv->wx_sem: locked (258) unlocked (262)

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl_wx.c
index 77ea4bb8c7a1..93b1edbe6bae 100644
--- a/drivers/staging/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl_wx.c
@@ -255,6 +255,7 @@ static int r8192se_wx_set_radio(struct net_device *dev,
 	if ((*extra != 0) && (*extra != 1)) {
 		RT_TRACE(COMP_ERR, "%s(): set radio an err value,must 0(radio "
 			 "off) or 1(radio on)\n", __func__);
+		up(&priv->wx_sem);
 		return -1;
 	}
 	priv->sw_radio_on = *extra;