From: Paul Gortmaker Date: Thu, 4 Jul 2013 05:39:11 +0000 (-0400) Subject: power_supply: Make goldfish_battery depend on GOLDFISH || COMPILE_TEST X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e2e077cdde5c6b0c7145849afcf0780e08190311;p=linux-beck.git power_supply: Make goldfish_battery depend on GOLDFISH || COMPILE_TEST Nearly all the other goldfish peripherals (mtd, keyboard, etc) have a dependency on the main platform's GOLDFISH Kconfig item, but this one got skipped. Even with consistency as a justification, there was initial resistance[1] from some people to adding it however, as they wanted the extra compile coverage. Now, with CONFIG_COMPILE_TEST, we have the middle ground that will give people the coverage who want it, and let those who don't want it to skip ever seeing the option presented. [1] https://lkml.org/lkml/2013/2/27/333 Cc: David Woodhouse Cc: Jiri Slaby Cc: Greg Kroah-Hartman Signed-off-by: Paul Gortmaker Signed-off-by: Anton Vorontsov --- diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig index 7b8979c63f48..dcc0d9e5817d 100644 --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -357,7 +357,7 @@ config AB8500_BM config BATTERY_GOLDFISH tristate "Goldfish battery driver" - depends on GENERIC_HARDIRQS + depends on GENERIC_HARDIRQS && (GOLDFISH || COMPILE_TEST) help Say Y to enable support for the battery and AC power in the Goldfish emulator.