From: Wei Yongjun Date: Fri, 15 Nov 2013 07:50:31 +0000 (+0800) Subject: spi: spi-mxs: fix reference leak to master in mxs_spi_remove() X-Git-Tag: next-20131128~21^2~2^5 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e322ce9365693b417867f6bd700ddf09cca36b37;p=karo-tx-linux.git spi: spi-mxs: fix reference leak to master in mxs_spi_remove() Once a spi_master_get() call succeeds, we need an additional spi_master_put() call to free the memory, otherwise we will leak a reference to master. Fix by removing the unnecessary spi_master_get() call. Fixes: 33e195acf268 ('spi: mxs: use devm_spi_register_master()') Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index de333059a9a7..37b3e41bf46f 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -565,7 +565,7 @@ static int mxs_spi_remove(struct platform_device *pdev) struct mxs_spi *spi; struct mxs_ssp *ssp; - master = spi_master_get(platform_get_drvdata(pdev)); + master = platform_get_drvdata(pdev); spi = spi_master_get_devdata(master); ssp = &spi->ssp;