From: Alexandros Batsakis <batsakis@netapp.com>
Date: Fri, 19 Dec 2008 03:55:16 +0000 (-0800)
Subject: nfsd: lock state around put client and delegation in nfsd4_cb_recall
X-Git-Tag: v2.6.30-rc1~183^2~71
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e37da04ed145d45c2a698d7cb373a7e1191fbe86;p=karo-tx-linux.git

nfsd: lock state around put client and delegation in nfsd4_cb_recall

not having the state locked before putting the client/delegation causes a bug.
Also removed the comment from the function header about the state being already locked

Signed-off-by: Alexandros Batsakis <batsakis@netapp.com>
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---

diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index c6804db33c17..3ddc9fb2e358 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -451,7 +451,6 @@ nfsd4_probe_callback(struct nfs4_client *clp)
 
 /*
  * called with dp->dl_count inc'ed.
- * nfs4_lock_state() may or may not have been called.
  */
 void
 nfsd4_cb_recall(struct nfs4_delegation *dp)
@@ -491,7 +490,9 @@ out_put_cred:
 	 * Success or failure, now we're either waiting for lease expiration
 	 * or deleg_return.
 	 */
+	nfs4_lock_state();
 	put_nfs4_client(clp);
 	nfs4_put_delegation(dp);
+	nfs4_unlock_state();
 	return;
 }