From: H Hartley Sweeten Date: Thu, 3 May 2012 00:57:17 +0000 (-0700) Subject: tty: mxser: local variables should not be exposed globally X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e391edb727f51094582d39a29a94a83bc9c014e8;p=linux-beck.git tty: mxser: local variables should not be exposed globally The variable 'mxser_port_ops' is only referenced in this file and should be marked static to prevent it from being exposed globally. Quites the sparse warning: warning: symbol 'mxser_port_ops' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten Cc: Jiri Slaby Acked-by: Alan Cox Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index c6f372dd5623..90cc680c4f0e 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -2326,7 +2326,7 @@ static const struct tty_operations mxser_ops = { .get_icount = mxser_get_icount, }; -struct tty_port_operations mxser_port_ops = { +static struct tty_port_operations mxser_port_ops = { .carrier_raised = mxser_carrier_raised, .dtr_rts = mxser_dtr_rts, .activate = mxser_activate,