From: Chen-Yu Tsai Date: Tue, 6 Jun 2017 05:59:24 +0000 (+0800) Subject: irqchip/sunxi-nmi: Document interrupt disabling and clearing at probe time X-Git-Tag: v4.13-rc1~190^2~9^2~29 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e3ece0d5a31a588ced938d09f30c870ed9b2a2a6;p=karo-tx-linux.git irqchip/sunxi-nmi: Document interrupt disabling and clearing at probe time The sunxi-nmi disables all its interrupts and clears any pending interrupts at probe time. Add comments documenting it, just to make it clear. Signed-off-by: Chen-Yu Tsai Signed-off-by: Marc Zyngier --- diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c index 177efb473c7d..9a7f6971cc3a 100644 --- a/drivers/irqchip/irq-sunxi-nmi.c +++ b/drivers/irqchip/irq-sunxi-nmi.c @@ -201,7 +201,10 @@ static int __init sunxi_sc_nmi_irq_init(struct device_node *node, gc->chip_types[1].regs.type = reg_offs->ctrl; gc->chip_types[1].handler = handle_edge_irq; + /* Disable any active interrupts */ sunxi_sc_nmi_write(gc, reg_offs->enable, 0); + + /* Clear any pending NMI interrupts */ sunxi_sc_nmi_write(gc, reg_offs->pend, SUNXI_NMI_IRQ_BIT); irq_set_chained_handler_and_data(irq, sunxi_sc_nmi_handle_irq, domain);