From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 7 Apr 2015 23:43:56 +0000 (+1000)
Subject: ocfs2: double evaluation concerns in mlog_errno()
X-Git-Tag: KARO-TXA5-2015-06-26~18^2~470
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e49af8449f7202eef1b9b889b2f98ab067729784;p=karo-tx-linux.git

ocfs2: double evaluation concerns in mlog_errno()

It won't happen in real life, but for consistency etc then we should
only evaluate the "st" parameter once.

Also, since not all callers use the new return, it causes at static
checker warning:
fs/ocfs2/export.c:138 ocfs2_get_dentry() warn: unchecked 'PTR_ERR'

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: alex chen <alex.chen@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/fs/ocfs2/cluster/masklog.h b/fs/ocfs2/cluster/masklog.h
index f96a51dd4be8..7fdc25a4d8c0 100644
--- a/fs/ocfs2/cluster/masklog.h
+++ b/fs/ocfs2/cluster/masklog.h
@@ -202,7 +202,7 @@ extern struct mlog_bits mlog_and_bits, mlog_not_bits;
 	    _st != AOP_TRUNCATED_PAGE && _st != -ENOSPC &&		\
 	    _st != -EDQUOT)						\
 		mlog(ML_ERROR, "status = %lld\n", (long long)_st);	\
-	st;								\
+	_st;								\
 })
 
 #define mlog_bug_on_msg(cond, fmt, args...) do {			\