From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 Dec 2014 18:49:39 +0000 (-0300)
Subject: [media] lirc_zilog: Deletion of unnecessary checks before vfree()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e8379ecff31c0a172cb2ccc7cf28c24b45f144cf;p=linux-beck.git

[media] lirc_zilog: Deletion of unnecessary checks before vfree()

The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---

diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
index 1ccf6262ab36..1e15d2cab727 100644
--- a/drivers/staging/media/lirc/lirc_zilog.c
+++ b/drivers/staging/media/lirc/lirc_zilog.c
@@ -730,11 +730,9 @@ static int send_boot_data(struct IR_tx *tx)
 static void fw_unload_locked(void)
 {
 	if (tx_data) {
-		if (tx_data->code_sets)
-			vfree(tx_data->code_sets);
+		vfree(tx_data->code_sets);
 
-		if (tx_data->datap)
-			vfree(tx_data->datap);
+		vfree(tx_data->datap);
 
 		vfree(tx_data);
 		tx_data = NULL;