From: Maurice Ma Date: Tue, 11 Oct 2011 10:52:13 +0000 (+0100) Subject: x86, efi: Convert efi_phys_get_time() args to physical addresses X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=e9a9eca517d4cd94e816538efc400257e34bc63e;p=mv-sheeva.git x86, efi: Convert efi_phys_get_time() args to physical addresses Because callers of efi_phys_get_time() pass virtual stack addresses as arguments, we need to find their corresponding physical addresses and when calling GetTime() in physical mode. Without this patch the following line is printed on boot, "Oops: efitime: can't read time!" Signed-off-by: Maurice Ma Signed-off-by: Matt Fleming Cc: Zhang Rui Cc: Matthew Garrett Link: http://lkml.kernel.org/r/1318330333-4617-1-git-send-email-matt@console-pimps.org Signed-off-by: Ingo Molnar --- diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index 37718f0f053..d2376eb7231 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -238,7 +238,8 @@ static efi_status_t __init phys_efi_get_time(efi_time_t *tm, spin_lock_irqsave(&rtc_lock, flags); efi_call_phys_prelog(); - status = efi_call_phys2(efi_phys.get_time, tm, tc); + status = efi_call_phys2(efi_phys.get_time, virt_to_phys(tm), + virt_to_phys(tc)); efi_call_phys_epilog(); spin_unlock_irqrestore(&rtc_lock, flags); return status;