From: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Sat, 5 Apr 2014 08:10:51 +0000 (+0200)
Subject: drm/ast: Remove unnecessary NULL check in bo_unref
X-Git-Tag: next-20140502~52^2~1^2~7
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=eb649a614d3a2204825cc41f32a7ae79ff74da35;p=karo-tx-linux.git

drm/ast: Remove unnecessary NULL check in bo_unref

ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---

diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
index 50535fd5a88d..38941a656312 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -411,10 +411,9 @@ static void ast_bo_unref(struct ast_bo **bo)
 
 	tbo = &((*bo)->bo);
 	ttm_bo_unref(&tbo);
-	if (tbo == NULL)
-		*bo = NULL;
-
+	*bo = NULL;
 }
+
 void ast_gem_free_object(struct drm_gem_object *obj)
 {
 	struct ast_bo *ast_bo = gem_to_ast_bo(obj);