From: Sachin Kamat Date: Fri, 21 Sep 2012 05:06:47 +0000 (+0530) Subject: video: exynos_mipi_dsi: Remove unnecessary NULL check X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ebe9f7b02590d870506ef493483fe4abdb08e967;p=linux-beck.git video: exynos_mipi_dsi: Remove unnecessary NULL check 'dsim' is allocated and checked for NULL in the probe function. Hence this check is redundant. This cleanup also fixes a potential NULL pointer dereference error when dsim which is NULL references its member in the error print message. Signed-off-by: Sachin Kamat Acked-by: Inki Dae Signed-off-by: Florian Tobias Schandinat --- diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c b/drivers/video/exynos/exynos_mipi_dsi_common.c index 7cc4113242d9..3cd29a4fc10a 100644 --- a/drivers/video/exynos/exynos_mipi_dsi_common.c +++ b/drivers/video/exynos/exynos_mipi_dsi_common.c @@ -79,11 +79,6 @@ irqreturn_t exynos_mipi_dsi_interrupt_handler(int irq, void *dev_id) struct mipi_dsim_device *dsim = dev_id; unsigned int intsrc, intmsk; - if (dsim == NULL) { - dev_err(dsim->dev, "%s: wrong parameter\n", __func__); - return IRQ_NONE; - } - intsrc = exynos_mipi_dsi_read_interrupt(dsim); intmsk = exynos_mipi_dsi_read_interrupt_mask(dsim); intmsk = ~intmsk & intsrc;