From: Lukasz Majewski Date: Wed, 28 Jan 2015 15:25:22 +0000 (+0100) Subject: thermal: exynos: Correct sanity check at exynos_report_trigger() function X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=eccb60145415dd8e171687cd1694f50141f50d6d;p=linux-beck.git thermal: exynos: Correct sanity check at exynos_report_trigger() function Up till now, by mistake, wrong variable was tested against being NULL. Since exynos_report_trigger() is always called with valid p pointer, it is only necessary to check if a valid thermal zone device is passed. Reported-by: Dan Carpenter Signed-off-by: Lukasz Majewski Signed-off-by: Eduardo Valentin --- diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 864eec8f5164..b6a6e90ba340 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -172,8 +172,8 @@ static void exynos_report_trigger(struct exynos_tmu_data *p) unsigned long temp; unsigned int i; - if (!p) { - pr_err("Wrong temperature configuration data\n"); + if (!tz) { + pr_err("No thermal zone device defined\n"); return; }