From: Stephan Mueller Date: Sun, 17 Aug 2014 15:38:58 +0000 (+0200) Subject: crypto: drbg - remove superflowous memset(0) X-Git-Tag: v3.18-rc1~132^2~27 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f072f0e0fe0f3758c7c94bee875564c89fd07d08;p=karo-tx-linux.git crypto: drbg - remove superflowous memset(0) Remove memset(0) which is not needed due to the kzalloc of the memory. Signed-off-by: Stephan Mueller Signed-off-by: Herbert Xu --- diff --git a/crypto/drbg.c b/crypto/drbg.c index 212d260220e3..86cffc600acd 100644 --- a/crypto/drbg.c +++ b/crypto/drbg.c @@ -728,11 +728,9 @@ static int drbg_hmac_update(struct drbg_state *drbg, struct list_head *seed, LIST_HEAD(seedlist); LIST_HEAD(vdatalist); - if (!reseed) { - /* 10.1.2.3 step 2 */ - memset(drbg->C, 0, drbg_statelen(drbg)); + if (!reseed) + /* 10.1.2.3 step 2 -- memset(0) of C is implicit with kzalloc */ memset(drbg->V, 1, drbg_statelen(drbg)); - } drbg_string_fill(&seed1, drbg->V, drbg_statelen(drbg)); list_add_tail(&seed1.list, &seedlist);