From: Clemens Ladisch <clemens@ladisch.de>
Date: Fri, 18 May 2012 16:00:43 +0000 (+0200)
Subject: ALSA: usb-audio: fix rate_list memory leak
X-Git-Tag: v3.2.20~43
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f139d067883637c9ab0091fbca821d01d0890123;p=karo-tx-linux.git

ALSA: usb-audio: fix rate_list memory leak

commit 5cd5d7c44990658df6ab49f6253c39617c53b03d upstream.

The array of sample rates is reallocated every time when opening
the PCM device, but was freed only once when unplugging the device.

Reported-by: "Alexander E. Patrakov" <patrakov@gmail.com>
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index 0220b0f335b9..839165fb7e5f 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -698,6 +698,9 @@ static int snd_usb_pcm_check_knot(struct snd_pcm_runtime *runtime,
 	int count = 0, needs_knot = 0;
 	int err;
 
+	kfree(subs->rate_list.list);
+	subs->rate_list.list = NULL;
+
 	list_for_each_entry(fp, &subs->fmt_list, list) {
 		if (fp->rates & SNDRV_PCM_RATE_CONTINUOUS)
 			return 0;