From: Ying Xue Date: Mon, 21 Apr 2014 02:55:49 +0000 (+0800) Subject: tipc: make media_ptr pointed netdevice valid X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f1c8d8cb82113ea6f41d2774127d3d08a4ca8d46;p=linux-beck.git tipc: make media_ptr pointed netdevice valid The 'media_ptr' pointer in bearer structure which points to network device, is protected by RCU. So, before netdevice is released, synchronize_net() should be involved to prevent no any user of the netdevice on read side from accessing it after it is freed. Signed-off-by: Ying Xue Reviewed-by: Jon Maloy Reviewed-by: Erik Hugne Tested-by: Erik Hugne Signed-off-by: David S. Miller --- diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 1bd96eb465e1..402e99472a63 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c @@ -471,6 +471,7 @@ void tipc_disable_l2_media(struct tipc_bearer *b) dev = (struct net_device *)rtnl_dereference(b->media_ptr); RCU_INIT_POINTER(b->media_ptr, NULL); RCU_INIT_POINTER(dev->tipc_ptr, NULL); + synchronize_net(); dev_put(dev); }