From: Roland Dreier <roland@purestorage.com>
Date: Tue, 3 May 2011 05:15:37 +0000 (-0700)
Subject: target: Fix double test of inquiry_prod
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f22c119683e73498d8126581a1be75e1b7a339a3;p=linux-beck.git

target: Fix double test of inquiry_prod

The code in transport_add_device_to_core_hba() really intends to make sure
that neither inquiry_prod nor inquiry_rev is NULL.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index e4406c9e66e0..6f5d4dfa14e8 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1623,7 +1623,7 @@ struct se_device *transport_add_device_to_core_hba(
 	 * setup.
 	 */
 	if (dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV) {
-		if (!(inquiry_prod) || !(inquiry_prod)) {
+		if (!inquiry_prod || !inquiry_rev) {
 			printk(KERN_ERR "All non TCM/pSCSI plugins require"
 				" INQUIRY consts\n");
 			goto out;