From: Matt Fleming Date: Fri, 19 Aug 2011 16:46:37 +0000 (+0100) Subject: OpenRISC: No need to reset handler if SA_ONESHOT X-Git-Tag: next-20110826~16^2~18 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f296753b6c9666042ff0d2f9378bc33a3c11edcb;p=karo-tx-linux.git OpenRISC: No need to reset handler if SA_ONESHOT get_signal_to_deliver() already resets the signal handler if SA_ONESHOT is set in ka->sa.sa_flags, there's no need to do it again in handle_signal(). Furthermore, because we were modifying ka->sa.sa_handler (which is a copy of sighand->action[]) instead of sighand->action[] the original code actually had no effect on signal delivery. Acked-by: Oleg Nesterov Cc: Jonas Bonn Cc: Arnd Bergmann Signed-off-by: Matt Fleming Signed-off-by: Oleg Nesterov --- diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c index c023db9be95d..2f75e74f4df7 100644 --- a/arch/openrisc/kernel/signal.c +++ b/arch/openrisc/kernel/signal.c @@ -267,9 +267,6 @@ handle_signal(unsigned long sig, { setup_rt_frame(sig, ka, info, oldset, regs); - if (ka->sa.sa_flags & SA_ONESHOT) - ka->sa.sa_handler = SIG_DFL; - spin_lock_irq(¤t->sighand->siglock); sigorsets(¤t->blocked, ¤t->blocked, &ka->sa.sa_mask); if (!(ka->sa.sa_flags & SA_NODEFER))