From: Akinobu Mita Date: Mon, 25 Jul 2011 00:49:51 +0000 (+1000) Subject: Using __test_and_{set,clear}_bit_le() with ignoring its return value X-Git-Tag: next-20110726~30^2~32 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f2f2d9be0d58ca87bd3f1f1e8a1c33ab3848fde1;p=karo-tx-linux.git Using __test_and_{set,clear}_bit_le() with ignoring its return value can be replaced with __{set,clear}_bit_le(). This also removes unnecessary casts. Signed-off-by: Akinobu Mita Signed-off-by: Alasdair G Kergon Cc: Alasdair Kergon --- diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c index 948e3f4925bf..2ef7e6ef5a7c 100644 --- a/drivers/md/dm-log.c +++ b/drivers/md/dm-log.c @@ -251,20 +251,20 @@ struct log_c { */ static inline int log_test_bit(uint32_t *bs, unsigned bit) { - return test_bit_le(bit, (unsigned long *) bs) ? 1 : 0; + return test_bit_le(bit, bs) ? 1 : 0; } static inline void log_set_bit(struct log_c *l, uint32_t *bs, unsigned bit) { - __test_and_set_bit_le(bit, (unsigned long *) bs); + __set_bit_le(bit, bs); l->touched_cleaned = 1; } static inline void log_clear_bit(struct log_c *l, uint32_t *bs, unsigned bit) { - __test_and_clear_bit_le(bit, (unsigned long *) bs); + __clear_bit_le(bit, bs); l->touched_dirtied = 1; } @@ -739,8 +739,7 @@ static int core_get_resync_work(struct dm_dirty_log *log, region_t *region) return 0; do { - *region = find_next_zero_bit_le( - (unsigned long *) lc->sync_bits, + *region = find_next_zero_bit_le(lc->sync_bits, lc->region_count, lc->sync_search); lc->sync_search = *region + 1;